Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: left padding for alerts with icons that aren't in the in root of the component #1254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: left padding for alerts with icons that aren't in the in root of the component #1254

wants to merge 1 commit into from

Conversation

walker-tx
Copy link
Contributor

Fixes #1177

See issue - it's pretty detailed on the problem and fix.

Default
Capture-2024-08-27-213215

New York (Wasn't Broken)
Capture-2024-08-27-213321

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: 701b69d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 701b69d

huntabyte
huntabyte approved these changes Aug 28, 2024
View reviewed changes
Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huntabyte huntabyte huntabyte approved these changes

@Louis-Bourgault Louis-Bourgault Louis-Bourgault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alert has left padding even when the icon is not a direct child
3 participants
@walker-tx @huntabyte @Louis-Bourgault